Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33692 )
Change subject: pySim/cards: Add type annotations ...................................................................... Patch Set 6: (1 comment) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/33692/comment/a3ac6ede_41ea504d PS6, Line 36: def __init__(self, scc: LinkBase): > I wonder if the constructor might also need an annotation for the returned > type (-> None)? PEP-0484 says we should ("ought"), but it's not strictly necessary, see: https://stackoverflow.com/a/73334605/10668583. Personally I always omit `-> None` in constructors. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id5752a64b59097584301c860ebf74d858ed3d240 Gerrit-Change-Number: 33692 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 13 Jul 2023 12:52:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
