Attention is currently required from: fixeria, pespin, daniel.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738 )

Change subject: gbprox_rx_ptp_from_bss: fix dangling pointer
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> Maybe it helps to set msgb_bcid() to 0 before returning from these functions?

Done, this fixes it.

> Also, I'm not able to reproduce this with "gcc version 12.3.0 (Debian 
> 12.3.0-6)"

The docker container currently has gcc (Debian 12.2.0-14) 12.2.0. On closer 
look, it actually passes the build initially without this patch but then fails 
later on during "make distcheck".



--
To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ie51e37572993cb5dc24ecf13bc300225f09cb744
Gerrit-Change-Number: 33738
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Fri, 14 Jul 2023 09:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment

Reply via email to