Attention is currently required from: osmith, jolly, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 )
Change subject: ASCI: Retrieve NCH position from System Information 1 ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/aa9c6689_ed7701bb PS6, Line 180: return -EINVAL; > Maybe log an error message here? It's not really an error, it's just "NCH not present" AFAIU. `EINVAL` may be confusing here, maybe `ENOENT` or `ENODEV`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I799a27179d478d4ff577d8bc47ae524834851e85 Gerrit-Change-Number: 33296 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Mon, 17 Jul 2023 13:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
