Attention is currently required from: fixeria, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/33690 )

Change subject: pySim/cards: Split legacy classes away from core SIM + UICC
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/33690/comment/594e5e00_51673824
PS4, Line 319: SimCard
> I personally would put a comment into UiccCardBase that describes the 
> situation. […]
I'll add that comment after the current patch series is merged to avoid too 
much fall-out.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1
Gerrit-Change-Number: 33690
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 17 Jul 2023 17:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to