Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/33833 )

Change subject: ASCI: Enable UPLINK ACCESS on various BTS models
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
I see this conditions "(lchan->ho.active == HANDOVER_ENABLED) || 
rsl_chan_rt_is_asci(lchan->rsl_chan_rt)" being used in different places and 
contexts, and it is not directly clear what's the meaning behind that check. It 
may make sense to have it as a static inline or define? as in "bool 
lchan_foobar(lchan)".



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33833
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iae0db6bfcf6629c114436a79648e832c82835abe
Gerrit-Change-Number: 33833
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Wed, 19 Jul 2023 14:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to