Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32922 )
Change subject: trxcon/l1sched: implement CSD scheduling support ...................................................................... Patch Set 11: (3 comments) File src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h: https://gerrit.osmocom.org/c/osmocom-bb/+/32922/comment/bc4c29d8_e9433c76 PS11, Line 198: /* Simple ring buffer (up to 24 unique measurements) */ some reference on why 24 may be great. Or using some define. File src/host/trxcon/src/sched_lchan_desc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32922/comment/dbec7697_df6707e4 PS11, Line 133: .burst_buf_size = 24 * GSM_NBITS_NB_GMSK_PAYLOAD, 24 everywhere. It will be really helpful for everyone to have a define. File src/host/trxcon/src/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32922/comment/c03b36d8_47ae5f4a PS11, Line 44: #define BUFMAX 24 here it is! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0d7389a9a5f7019b9316ab1c0115797ff54a0e41 Gerrit-Change-Number: 32922 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 19 Jul 2023 15:02:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
