Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 )
Change subject: sm: Handle GMMSM-MODIFY.ind primitive ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File include/osmocom/gprs/sm/sm_private.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/33811/comment/72a2165d_a63f6330 PS6, Line 159: struct osmo_gprs_sm_prim *gprs_sm_prim_alloc_smreg_pdp_deact_ind(void); > It's just part of the handling of GMMSM-MODIFY.ind, see the rest of the > patch. […] Ack File src/sm/sm_prim.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/33811/comment/1f658656_7508e1b5 PS6, Line 603: */ > Yes, this is not really needed for now since it's for acknowledged mode, > which afaik we are not even […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic765b7a565cac4abcf34d8c6868e103971d17822 Gerrit-Change-Number: 33811 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 20 Jul 2023 11:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
