Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33977 )

Change subject: ASCI: Add integer type to BSC_ConnHdlr_Coord_PT port
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
when are we doing this?  As TTCN-3 is a very type-heavy language, I think it 
would be better to have a specific type (like an enumerated, ...) that can be 
used here than a random integer.  The advantage is that in log files you'd get 
a meaningful decode (string name) of the enum.  Furthermore, you avoid any 
mis-interpretation of raw integer values.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2bb9bec5b084ad5e2a46caa91d1908d2c6781132
Gerrit-Change-Number: 33977
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Thu, 27 Jul 2023 17:11:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to