Attention is currently required from: lynxis lazus.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/33985 )

Change subject: Reimplement ust_service_activate and ust_service_deactivate for 
USIM/EF.UST
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
nice catch. I'm most surprised that our tests don't cover this, so we should 
definitely extend those to cover it.

in terms of binascii: we have our own b2h/h2b functions in pySim.utils, and all 
other code uses that. might be best to align with it?



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33985
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7a6a77b872a6f5d8c478ca75dcff8ea067b8203e
Gerrit-Change-Number: 33985
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Fri, 28 Jul 2023 07:20:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to