Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/5572/1/src/sccp_scoc.c File src/sccp_scoc.c: Line 1626: LOGP(DLSCCP, LOGL_ERROR, "Cannot create conn-id for primitive %s\n", "inform the user" in the context of the SCCP-User-SAP means "send him the respective primitive as described by the ITU-T Q.7xx specs". I would expect a N-DISCONNET.ind with apropriate cause. -- To view, visit https://gerrit.osmocom.org/5572 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
