laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/33965 )
Change subject: ASCI: Add debugging and error logging to VGCS/VBS call control
......................................................................
ASCI: Add debugging and error logging to VGCS/VBS call control
Change-Id: I3fbce71e47e9670f58e46e7c2a0f26a1bbc1a46e
Related: OS#4854
---
M src/libmsc/msc_vgcs.c
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c
index f50753b..e713ba5 100644
--- a/src/libmsc/msc_vgcs.c
+++ b/src/libmsc/msc_vgcs.c
@@ -636,6 +636,7 @@
}
/* Create BSS list structures. */
+ LOG_GCC(trans, LOGL_DEBUG, "Creating BSS list structure with cell list
structures.\n");
llist_for_each_entry(b, &gcr->bss_list, list) {
LOG_GCC(trans, LOGL_DEBUG, " -> BSS with PC %s.\n",
osmo_ss7_pointcode_print(NULL, b->pc));
/* Resolve ran_peer. */
@@ -668,12 +669,14 @@
/* Create ran connection. */
bss->conn = ran_conn_create_outgoing(rp);
if (!bss->conn) {
+ LOG_GCC(trans, LOGL_ERROR, "Failed to create RAN
connection.\n");
osmo_fsm_inst_free(bss->fi);
continue;
}
bss->conn->vgcs.bss = bss;
/* Create cell list structures. */
llist_for_each_entry(c, &b->cell_list, list) {
+ LOG_GCC(trans, LOGL_DEBUG, " -> Cell ID %d.\n",
c->cell_id);
/* Create state machine. */
fi = osmo_fsm_inst_alloc(&vgcs_cell_fsm, net, NULL,
LOGL_DEBUG, NULL);
if (!fi) {
@@ -698,6 +701,7 @@
/* Create ran connection. */
cell->conn = ran_conn_create_outgoing(rp);
if (!cell->conn) {
+ LOG_GCC(trans, LOGL_ERROR, "Failed to create
RAN connection.\n");
osmo_fsm_inst_free(cell->fi);
continue;
}
@@ -710,6 +714,7 @@
}
/* No cell? */
if (llist_empty(&bss->cell_list)) {
+ LOG_GCC(trans, LOGL_DEBUG, " -> No Cell in this
BSS.\n");
osmo_fsm_inst_free(bss->fi);
break;
}
@@ -721,6 +726,7 @@
/* No BSS? */
if (llist_empty(&trans->gcc.bss_list)) {
/* Also destroy MGW, because this list is empty too! */
+ LOG_GCC(trans, LOGL_NOTICE, "No BSS found, please check your
VTY configuration and add cells.\n");
goto err_mgw;
}
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33965
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3fbce71e47e9670f58e46e7c2a0f26a1bbc1a46e
Gerrit-Change-Number: 33965
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
