Attention is currently required from: arehbein, laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )
Change subject: stream: Add server-side (segmentation) support for IPA ...................................................................... Patch Set 13: (2 comments) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/cbe57ba9_19151a37 PS10, Line 540: osmo_stream_cli_set_addr(osc, "127.0.0.11"); > I don't understand the second part of the sentence... […] What I meant is that in linux for the loopback interface the range 127.0.0.X of addresses don't need to explicitly be assigned to the network interface, they are added automagically when needed. Not critical, just sharing that this may pose problems on other systems. https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/52147af6_055fb052 PS10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start); > What is the advantage of using `alarm()` instead, and how wouldn't I need to > register some sort of ( […] The advantage is not mixing the code testing the API with the test-code itself. That makes the test easier to read, easier to extend, easier to debug. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 13 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 09:11:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
