Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 )
Change subject: rlcmac: keep looking up GRE based on old TLLI ...................................................................... Patch Set 1: (1 comment) File src/rlcmac/rlcmac.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34023/comment/b3e25319_77c3bc99 PS1, Line 140: if (gre->tlli == tlli || gre->old_tlli == tlli) > It's probably the case but I'm wondering if calling code makes sure that tlli > != GPRS_RLCMAC_TLLI_UN […] it doesn't mark snse to lookup tlli based on GPRS_RLCMAC_TLLI_UNASSIGNED, so in any case that's a separate bug in any caller which would need to be fixed. I'm not really worried by this right now tbh. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f Gerrit-Change-Number: 34023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:36:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
