Attention is currently required from: arehbein, pespin.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )

Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................


Patch Set 17:

(2 comments)

File tests/stream/stream_test.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/52cc603c_b6c847ec
PS13, Line 829:         rc = clock_gettime(CLOCK_MONOTONIC, &start);
> I think I already answered in there that the easiest/best way to timeout the 
> test is to use the alar […]
Done


File tests/stream/stream_test.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/69687a7a_e31cb863 
PS16, Line 518:                 osmo_timer_schedule(&fragmented_send_tl_cli, 0, 
125000);
> why this change in time? seems unrelated?
Looks like it. Doesn't really matter except for the "timestamp" in the log 
output, though.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 17
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 07 Aug 2023 16:02:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to