Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33732 )
Change subject: Tx Loc UPD ACC: Use PLMN provided by subscr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This patch looks +2 worthy, but I'm missing a motivation in the commit log -- these points are important: - remind us, where exactly is the vsub->cgi PLMN coming from? (Compl L3 Info? Which IE exactly?) - in what *valid* situation would the PLMN differ? - in what way is it an improvement to take vsub->cgi's PLMN? I expect it all makes sense, but currently am not sure... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I421bd63a264db2bf6e1c4a4eea976f389e87b332 Gerrit-Change-Number: 33732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 08 Aug 2023 02:18:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
