Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34081 )
Change subject: stream: Refactor sctp_recvmsg_wrapper() logging ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34081/comment/358b469d_739d50fd PS1, Line 834: static int _sctp_recvmsg_wrapper(int fd, struct msgb *msg) > the problem I always had with this function that it doesn't differentiate the > log level based on the […] Done https://gerrit.osmocom.org/c/libosmo-netif/+/34081/comment/e9fb00c3_d6097cfb PS1, Line 848: LOGP(DLINP, LOGL_DEBUG, "NOTIFICATI > another even more critical problem of this function is that it logs no contxt > whatsoever. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31 Gerrit-Change-Number: 34081 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 09 Aug 2023 14:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
