Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34141 )

Change subject: l1gprs: Improve logging fn and tn in BLOCK.req
......................................................................


Patch Set 2:

(2 comments)

File src/shared/l1gprs.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34141/comment/d4886f86_5c1172b2
PS1, Line 635: tn=%u
> Printing `tn` is redundant here because `LOGP_PDCH` does print timeslot 
> number of the respective PDC […]
Ack


https://gerrit.osmocom.org/c/osmocom-bb/+/34141/comment/9f2a49e4_aeda45a4
PS1, Line 640: tn=%u
> Same here.
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34141
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52
Gerrit-Change-Number: 34141
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 10 Aug 2023 18:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to