Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34139 )

Change subject: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

File include/l1gprs.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/b3f61618_7fdd15ca
PS2, Line 37: void *priv
> I really prefer passing the priv pointer as a param. […]
Done


https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/99035f93_a179017a
PS2, Line 48: changed_cb
> I'll look into this.
Looks good to me now, thanks!



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34139
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4c2ff25217fba0b6b4704f023071b86ed9afb55c
Gerrit-Change-Number: 34139
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 11 Aug 2023 18:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to