Attention is currently required from: laforge, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34105 )

Change subject: pcuif_proto: remove unnecessary members from 
gsm_pcu_if_data_cnf_dt
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Patchset:

PS1:
> a msg_id assigned by PCU is certainly enough, since it's the PCU taking care 
> of internally keeping s […]
I wonder if Ericsson really uses the TLLI as an identifier. Maybe that is only 
what we first assumed when we saw that it is a 4 byte identifier. As far as I 
remember they call it a "Mobile Identifier", so it's not explicitly said that 
the identifier has to be a TLLI.

I have had also a look at the IMMEDIATE ASSIGNMENT SENT message. There we only 
get the "Mobile Identifier" back, but not the frame number or anything other 
that would make the confirmation more unique.

So yes, we should do the actual matching in the PCU, then we can improve this 
from there and hand out guaranteed unique identifiers later.


PS1:
All the corresponding patches were ready and are merged. I think we can merge 
this one too, so I add +2 now.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34105
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I779605858648e2a1c202c37e197a6e32e6ea3786
Gerrit-Change-Number: 34105
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 17 Aug 2023 15:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to