Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 )
Change subject: asp: Allow setting IP address as SCTP primary upon conn establishment ...................................................................... Patch Set 3: (4 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/43d2e6c0_85f75efb PS3, Line 1285: if (idx_primary >= (int)host_cnt) How about: ``` if (idx_primary >= (int)host_cnt || idx_primary < -1) ``` https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/cef205ed_a2314bf3 PS3, Line 1382: is_primary is_primary_addr https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/d321dd53_bfb5b928 PS3, Line 1402: an "an" is wrong here https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/469c425e_ede9ecb2 PS3, Line 2067: rc = previous rc gets overwritten here (check it before?), same in xua_accept_cb() -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4a9fc1a4ad82ed20ece328bc53fca58299d744ca Gerrit-Change-Number: 34111 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:13:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
