Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 )

Change subject: rlcmac: ul_tbf: Implement TBF_Starting time (phase1)
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-gprs/+/34046/comment/20bd003b_17da774d
PS8, Line 9: since lower layers are always
           : sending hardcoded fn=0
> We already have a patch fixing this in review, so not sure if this should be 
> in the commit message.
I think it's fine, since it's still actually true (not merged yet) and provides 
feedback on historially related topics.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If6b7766ee1ba6667db4e54e897f376f5b27ad73d
Gerrit-Change-Number: 34046
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 23 Aug 2023 11:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to