Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32536 )
Change subject: osmo_io: Add io_uring backend ...................................................................... Patch Set 12: (2 comments) File tests/osmo_io/osmo_io_test.c: https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/dc3331f5_1340909e PS12, Line 99: for (int i = 0; i < 128; i++) > why is this needed? In io_uring there is still a queue submitted for the read/receive call. After osmo_iofd_free() this read completes (with an error) / is aborted and we return the queue entry and actually free the osmo_io_fd. (Without this leak sanitizer reports a mem leak.) https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/c32950cc_455175a0 PS12, Line 155: osmo_select_main(1); > why is this needed? see above -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5152129eb84b31ccc9e02bc2a5c5bdb046d331bc Gerrit-Change-Number: 32536 Gerrit-PatchSet: 12 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 23 Aug 2023 17:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
