Attention is currently required from: pespin, dexter.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34191 )

Change subject: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch
......................................................................


Patch Set 1:

(1 comment)

File include/osmo-bts/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-bts/+/34191/comment/2ac37623_217744e6
PS1, Line 235:  bool confirmed_imm_ass;
Wwhat happens if using a newer osmo-bts with an older osmo-pcu which does not 
send the field?

Otherwise LGTM.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34191
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3364d2268bdef9c4d2feeb8e3d51a64e34bca68c
Gerrit-Change-Number: 34191
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 24 Aug 2023 12:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to