Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34188 )
Change subject: debian: depend on liburing-dev for debian >= 11 ...................................................................... Patch Set 1: (2 comments) File debian/control: https://gerrit.osmocom.org/c/libosmocore/+/34188/comment/d9e186e6_604bbd06 PS1, Line 22: base-files (<< 11) | liburing-dev, > what does this mean? base-files is a package installed in all debian distributions and their derivatives, like ubuntu. It has the version of the debian distribution, e.g. 12.4+deb12u1 currently on bookworm, and 12.3ubuntu2 on ubuntu 23.04. * https://packages.debian.org/search?suite=all&searchon=names&keywords=base-files * https://packages.ubuntu.com/search?keywords=base%2Dfiles So what this means is: * require base-files with a version less than 11 (which is only possible on debian 10 and below, and there it is already installed so we are not pulling in another dependency) * otherwise require liburing-dev File debian/rules: https://gerrit.osmocom.org/c/libosmocore/+/34188/comment/a632262b_b1a3311f PS1, Line 36: base_ver="$$(dpkg -l base-files | grep "^ii" | awk '{print $$3}')"; \ > A quite convoluted way to find the version. Did you think about > https://manpages.debian. […] This uses /etc/os-release and /usr/lib/os-release. In ubuntu this doesn't contain the debian version it is based on. In general I just wanted to check exactly for the same version of base-files as done in the debian/control file, so I did it like this. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34188 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If7832baec0bddbe0bbbbfe07f77bba3deb328d5c Gerrit-Change-Number: 34188 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 24 Aug 2023 14:03:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
