Attention is currently required from: osmith.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/34190 )

Change subject: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/34190/comment/896f5246_373cdace
PS1, Line 17: Depends: osmo-pcu.git Ia202862aafc1f0cb6601574ef61eb9155de11f04
> this patch depends on this patch? :)
Done


File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34190/comment/419119f8_08eb8cc8
PS1, Line 303: imm_ass
> As somebody not so familiar with the code, I find it confusing that the 
> variable gets a different na […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04
Gerrit-Change-Number: 34190
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Fri, 25 Aug 2023 10:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Gerrit-MessageType: comment

Reply via email to