Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34191 )
Change subject: pcuif_proto: use confirm flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34191/comment/8e53835b_2bc18649 PS1, Line 11: > I'd mention here that the flag gets added in osmo-pcu. […] Done File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/34191/comment/d4f4e26f_70ae8bf0 PS1, Line 235: bool confirmed_imm_ass; > Wwhat happens if using a newer osmo-bts with an older osmo-pcu which does not > send the field? […] The version flag in pcuif_proto.h should catch that. Otherwise: DL TBFs would not work since the confirm flag would be always zero. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3364d2268bdef9c4d2feeb8e3d51a64e34bca68c Gerrit-Change-Number: 34191 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Fri, 25 Aug 2023 10:32:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
