Patch Set 1: Code-Review+1 (1 comment)
Looks good to me, thanks. https://gerrit.osmocom.org/#/c/5615/1/src/osmo-bsc_nat/bsc_nat_rewrite.c File src/osmo-bsc_nat/bsc_nat_rewrite.c: Line 343: static bool sms_encode_addr_element(struct msgb *out, const char *new_number, Hmm, I thought we don't really use bool in our code, but a quick grep reveals that it is actually used nowadays. -- To view, visit https://gerrit.osmocom.org/5615 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fc16e24f7df5ebad6f4f1b389b2c5e861be95d7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-HasComments: Yes
