Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255 )
Change subject: dia2gsup: Introduce new error scenario tests ...................................................................... Patch Set 1: (1 comment) File dia2gsup/DIA2GSUP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255/comment/7feb8b8d_b6217598 PS1, Line 345: TC_authinfo_gsup_err_imsi_unknown > It depends on the angle you look at it. […] Given that what this app does is basically translating stuff, I think it makes sense to check specifically different values/cases independently to make sure the translation is fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34255 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic870a2c1de74bee3f7d8e26874635d58469ccbea Gerrit-Change-Number: 34255 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 31 Aug 2023 08:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
