laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/34273 )
Change subject: m3ua: Add some TODO comments on where we fall short of our
potential
......................................................................
m3ua: Add some TODO comments on where we fall short of our potential
Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e
---
M src/m3ua.c
M src/xua_as_fsm.c
2 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/73/34273/1
diff --git a/src/m3ua.c b/src/m3ua.c
index 85ac974..f4dbf76 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -462,9 +462,11 @@
return NULL;
}
- if (xua->hdr.msg_class == M3UA_MSGC_XFER)
+ if (xua->hdr.msg_class == M3UA_MSGC_XFER) {
+ /* TODO: M3UA RFC says that multiple different streams within
the SCTP association
+ * *may* be used, for example, by using the SLS value. Not
required but makes sense. */
msgb_sctp_stream(msg) = 1;
- else
+ } else
msgb_sctp_stream(msg) = 0;
msgb_sctp_ppid(msg) = M3UA_PPID;
diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index 2b16139..e239c74 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -158,6 +158,8 @@
asp = xua_as_select_asp_override(as);
break;
case OSMO_SS7_AS_TMOD_LOADSHARE:
+ /* TODO: actually use the SLS value to ensure same SLS goes
through same ASP. Not
+ * strictly required by M3UA RFC, but would fit the overall
principle. */
case OSMO_SS7_AS_TMOD_ROUNDROBIN:
asp = xua_as_select_asp_roundrobin(as);
break;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34273
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e
Gerrit-Change-Number: 34273
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange
