Attention is currently required from: pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269 )

Change subject: NAS_Templates: add template for EPS update type
......................................................................


Patch Set 1:

(1 comment)

File library/NAS_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269/comment/8f91c35b_16369eb5
PS1, Line 320: const BIT3 c_EPS_UPD_TYPE_TA_UPD := '000'B;
> this should be an enum afaiu.
One could define the enum like so:

type enumerated typeOfUpdate_t {
        c_EPS_UPD_TYPE_TA_UPD                           ('000'B),
        c_EPS_UPD_TYPE_COMB_TA_LA_UPD                   ('001'B),
        c_EPS_UPD_TYPE_COMB_TA_LA_UPD_IMSI_ATTACH       ('010'B),
        c_EPS_UPD_TYPE_TA_UPD_PERIODIC                  ('011'B)
};

But I can get this to work. When I use the type, then the compiler complains 
that the type is not a bitstring (!?), when I am stick using BIT3 it says there 
is no local or imported definition of..

Also in this file there are also other constants that are defined in the same 
way I did, so I am not sure if using two different ways to define/organize 
constants is a good idea anyway.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6ffac88cc1d3967dc8000e17a65cdba79a013cf7
Gerrit-Change-Number: 34269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 01 Sep 2023 08:41:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to