Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31304 )
Change subject: Includes: Remove enum/include from libosmocore instead ...................................................................... Patch Set 7: (1 comment) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/fe3a8687_384cc4ad PS6, Line 657: uint16_t parameter[_NUM_NM_RLC_PAR_OFFSET]; > I added the suffix, because this makes clear (self-documenting code and such) > that their values aren […] This all needs to be reverted. As explained in the libocmocore patch, this is all app-specific stuff and makes no sense trying to share it. In fact, it probably makes sense to drop the array alltogether and use a struct with proper fields instead. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2883aee12b501a717d5acecd5638882724336e72 Gerrit-Change-Number: 31304 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Comment-Date: Fri, 01 Sep 2023 16:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
