Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278 )

Change subject: BTS_Tests: decouple payload generation from f_rtpem_activate()
......................................................................


Patch Set 1:

(1 comment)

File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278/comment/d812e4e8_55df2f36
PS1, Line 2610: friend function f_rtpem_activate(RtpemConfig cfg := 
c_RtpemDefaultCfg,
> so cfg is not changed here? only "in"?
Correct, it's not being changed [anymore] and passed to the `RTP_Emulation` as 
is.
But if we go for `in`, then we cannot assign the default value anymore, can we?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e823c33b1dbbadd57bc63df25b8ddf368d76232
Gerrit-Change-Number: 34278
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 01 Sep 2023 21:01:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to