fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34298 )
Change subject: oml: ipacc: send NM_ATT_IPACC_RLC_CFG_3 if EGPRS is supported
......................................................................
oml: ipacc: send NM_ATT_IPACC_RLC_CFG_3 if EGPRS is supported
Change-Id: Ie0fb3eaf76e1f70e5a19bb088e1674b7e553d32a
---
M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
1 file changed, 18 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/34298/1
diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
index d78f23b..84169b6 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
@@ -209,15 +209,15 @@
};
msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_2, sizeof(rlc_cfg_2), (const
uint8_t *)&rlc_cfg_2);
-#if 0
- /* EDGE model only, breaks older models.
- * Should inquire the BTS capabilities */
- struct abis_nm_ipacc_att_rlc_cfg_3 rlc_cfg_3;
- rlc_cfg_3 = (struct abis_nm_ipacc_att_rlc_cfg_3){
- .initial_mcs = 2, /* MCS2 */
- };
- msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_3, sizeof(rlc_cfg_3), (const
uint8_t *)&rlc_cfg_3);
-#endif
+ if (osmo_bts_has_feature(&bts->features, BTS_FEAT_EGPRS)) {
+ /* EDGE model only, breaks older models */
+ struct abis_nm_ipacc_att_rlc_cfg_3 rlc_cfg_3;
+ rlc_cfg_3 = (struct abis_nm_ipacc_att_rlc_cfg_3){
+ .initial_mcs = 2, /* MCS2 */
+ };
+ msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_3,
+ sizeof(rlc_cfg_3), (const uint8_t *)&rlc_cfg_3);
+ }
return msgb;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34298
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fb3eaf76e1f70e5a19bb088e1674b7e553d32a
Gerrit-Change-Number: 34298
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-MessageType: newchange
