pespin has submitted this change. (
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: server_cb: use a define for the VENDOR_3GPP code
......................................................................
server_cb: use a define for the VENDOR_3GPP code
Also use a proper variable name
Change-Id: I9bd99998963624f7688b972cbb3908fae5686231
---
M src/server_cb.erl
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/server_cb.erl b/src/server_cb.erl
index 26a7ac2..862b9e7 100644
--- a/src/server_cb.erl
+++ b/src/server_cb.erl
@@ -6,6 +6,7 @@
-include_lib("diameter_3gpp_ts29_272.hrl").
-include_lib("osmo_gsup/include/gsup_protocol.hrl").
+-define(DIA_VENDOR_3GPP, 10415).
%% diameter callbacks
-export([peer_up/3, peer_down/3, pick_peer/4, prepare_request/3,
prepare_retransmit/3,
@@ -180,7 +181,7 @@
-define(GMM_CAUSE_INV_MAND_INFO, 16#60).
-define(GMM_CAUSE_PROTO_ERR_UNSPEC, 16#6f).
--define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=10415,
'Experimental-Result-Code'=Foo}).
+-define(EXP_RES(Exp), #'Experimental-Result'{'Vendor-Id'=?DIA_VENDOR_3GPP,
'Experimental-Result-Code'=Exp}).
%% see 29.272 Annex A/B
-type empty_or_intl() :: [] | [integer()].
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I9bd99998963624f7688b972cbb3908fae5686231
Gerrit-Change-Number: 34282
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
