Attention is currently required from: fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email )

Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-bsc/bts_siemens_bs11.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34321/comment/bb23f193_f8a8572f
PS1, Line 466: GSM_BTS_TYPE_BS11
you can also remove that check here in a similar manner.

I think the real cause of this is that we used to do this upon receiving a 
signal.  And that signal would get sent to all of the BTS models/drivers, and 
each signal handler had to make sure it only cares about its matching BTSs.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2
Gerrit-Change-Number: 34321
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 06 Sep 2023 13:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to