Attention is currently required from: osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34395?usp=email )

Change subject: OBS: don't downgrade version in debian/changelog
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File scripts/obs/lib/debian.py:

https://gerrit.osmocom.org/c/osmo-ci/+/34395/comment/cfa283cd_0de6c980
PS1, Line 101:     if packaging.version.parse(version_changelog.split("-")[0]) 
> \
isn0t this going to crash if you didn't successfuly import packaging.version? 
You probably need to add an exception handling here?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34395?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I550ed10a60c863626d870e35034028f0bd066211
Gerrit-Change-Number: 34395
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Tue, 12 Sep 2023 15:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to