Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email )
Change subject: sdp_get_sdp_mode(): fix wrong return value ...................................................................... Patch Set 1: (1 comment) File src/sdp.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410/comment/4decfd5c_690fb7e1 PS1, Line 68: return sdp_sendrecv; > where the hell is this symbol coming from? I can't see it in this function. sdp_sendrecv is enum sdp_mode_t from sofia-sip. It makes sense to use it elsewhere, but this here must be a typo in the original I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Id27eb82a018293cf54d068877dc222e1c7eab253 Gerrit-Change-Number: 34410 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 14 Sep 2023 00:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
