Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email )
Change subject: ASCI: Add channel notification event to MM events ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/b386c011_6699f34d PS5, Line 170: uint8_t sres[4]; > the sres is used with all events? or with some specific event only? Looks like we want a `union` here. https://gerrit.osmocom.org/c/osmocom-bb/+/34488/comment/0ccb5013_f1ff9408 PS5, Line 176: notification btw, this struct is not going to be packed even though it's defined in a packed struct. Not sure if this is really important, since it's not actually being sent over the wire, but JFYI. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342 Gerrit-Change-Number: 34488 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 22:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
