Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34490?usp=email )
Change subject: ASCI: Add channel description to messages from MM to RR layer ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34490/comment/168e55f4_74d093b8 PS5, Line 65: struct gsm48_chan_desc ch_desc; > did you check all users of this struct to make sure eveyrthing is updated? Is > this field always pres […] Ack, having a complete Information Element within a header definition looks wrong. File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34490/comment/4e7fac17_ca2e4bd3 PS5, Line 871: struct gsm48_chan_desc *ch_desc `const` -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I154f1f0e49ffa508d01a026da8e73faa7fdbab40 Gerrit-Change-Number: 34490 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 22:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
