pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500?usp=email )
Change subject: GPRS_Components: confirm only when requested
......................................................................
GPRS_Components: confirm only when requested
We currently send a confirmation back when the SAPI was PCH. This is no
longer correct. We now have to check if the receiving end has actually
requested a confirmation.
Related: OS#5927
Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2
---
M pcu/GPRS_Components.ttcn
1 file changed, 22 insertions(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index aaec6d3..849a251 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -1070,8 +1070,10 @@
t_imm_ass)) -> value data_msg {
rr_imm_ass := data_msg.rr_msg;
log("Rx Immediate Assignment: ", rr_imm_ass);
- /* Send DATA.cnf back to the IUT (only needed for PCH) */
- f_pcuif_tx_data_cnf(data_msg);
+ /* Send DATA.cnf back to the IUT */
+ if (ispresent(data_msg.confirm) and data_msg.confirm) {
+ f_pcuif_tx_data_cnf(data_msg);
+ }
setverdict(pass);
}
}
@@ -1187,8 +1189,10 @@
f_shutdown(__BFILE__, __LINE__);
}
- /* Send DATA.cnf back to the IUT (only needed for PCH) */
- f_pcuif_tx_data_cnf(data_msg);
+ /* Send DATA.cnf back to the IUT */
+ if (ispresent(data_msg.confirm) and data_msg.confirm) {
+ f_pcuif_tx_data_cnf(data_msg);
+ }
return rr_pag_req1;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34500?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2
Gerrit-Change-Number: 34500
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
