laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34418?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: sip: make mncc_with_sdp := true the default
......................................................................
sip: make mncc_with_sdp := true the default
A preceding patch has added mncc_with_sdp, defaulting to false.
So far just two new tests use mncc_with_sdp := true, but operation
without SDP is now merely the legacy compatibility mode, and I would
rather nudge new tests towards mncc_with_sdp := true.
So switch the default to mncc_with_sdp := true.
Change-Id: Ic9871917c57a9ab81b2fff0af7f569b09015910c
---
M sip/SIP_Tests.ttcn
1 file changed, 25 insertions(+), 8 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/sip/SIP_Tests.ttcn b/sip/SIP_Tests.ttcn
index 1904c6a..208cc01 100644
--- a/sip/SIP_Tests.ttcn
+++ b/sip/SIP_Tests.ttcn
@@ -82,7 +82,7 @@
integer sip_seq_nr
}
-private template (value) CallPars t_CallPars(boolean is_mo, boolean
mncc_with_sdp := false) := {
+private template (value) CallPars t_CallPars(boolean is_mo, boolean
mncc_with_sdp := true) := {
is_mo := is_mo,
calling := "12345",
called := "98766",
@@ -543,7 +543,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(false));
+ pars.g_cp := valueof(t_CallPars(false, false));
vc_conn := f_start_handler(refers(f_TC_mt_success_rel_gsm), pars);
vc_conn.done;
}
@@ -552,7 +552,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(false));
+ pars.g_cp := valueof(t_CallPars(false, false));
pars.g_cp.sip_rtp_addr := "::1";
pars.g_cp.cn_rtp_addr := "::2";
vc_conn := f_start_handler(refers(f_TC_mt_success_rel_gsm), pars);
@@ -580,7 +580,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(false));
+ pars.g_cp := valueof(t_CallPars(false, false));
vc_conn := f_start_handler(refers(f_TC_mt_success_rel_sip), pars);
vc_conn.done;
}
@@ -607,7 +607,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(true));
+ pars.g_cp := valueof(t_CallPars(true, false));
vc_conn := f_start_handler(refers(f_TC_mo_success_rel_gsm), pars);
vc_conn.done;
}
@@ -616,7 +616,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(true));
+ pars.g_cp := valueof(t_CallPars(true, false));
pars.g_cp.sip_rtp_addr := "::1";
pars.g_cp.cn_rtp_addr := "::2";
vc_conn := f_start_handler(refers(f_TC_mo_success_rel_gsm), pars);
@@ -644,7 +644,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(is_mo := true));
+ pars.g_cp := valueof(t_CallPars(is_mo := true, mncc_with_sdp := false));
vc_conn := f_start_handler(refers(f_TC_mo_success_rel_sip), pars);
vc_conn.done;
}
@@ -699,7 +699,7 @@
var ConnHdlr vc_conn;
f_init();
pars := valueof(t_Pars);
- pars.g_cp := valueof(t_CallPars(is_mo := true));
+ pars.g_cp := valueof(t_CallPars(is_mo := true, mncc_with_sdp := false));
vc_conn := f_start_handler(refers(f_TC_mo_setup_disc_late_rtp), pars);
vc_conn.done;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34418?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic9871917c57a9ab81b2fff0af7f569b09015910c
Gerrit-Change-Number: 34418
Gerrit-PatchSet: 6
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
