fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34594?usp=email )
Change subject: meas: fix ts45008_83_is_sub(): DTX is permitted on TCH/F sign
......................................................................
meas: fix ts45008_83_is_sub(): DTX is permitted on TCH/F sign
DTX is not allowed for TCH/H in signalling mode, but *is* allowed
for TCH/F in signalling mode.
Change-Id: I91cfd8f561eb47a5fc48c0682d56331a1d69aded
Related: OS#6168
---
M src/common/measurement.c
1 file changed, 14 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/src/common/measurement.c b/src/common/measurement.c
index e02dbe6..db3cdc1 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -59,6 +59,7 @@
switch (lchan->type) {
case GSM_LCHAN_TCH_F:
switch (lchan->tch_mode) {
+ case GSM48_CMODE_SIGN: /* TCH/F sign: DTX *is* permitted */
case GSM48_CMODE_SPEECH_V1:
case GSM48_CMODE_SPEECH_V1_VAMOS:
case GSM48_CMODE_SPEECH_EFR:
@@ -70,10 +71,6 @@
if (fn104 == 52)
return true;
break;
- case GSM48_CMODE_SIGN:
- /* No DTX allowed; SUB=FULL, therefore measurements at
all frame numbers are
- * SUB */
- return true;
case GSM48_CMODE_DATA_12k0: /* TCH/F9.6 */
case GSM48_CMODE_DATA_6k0: /* TCH/F4.8 */
/* FIXME: In case of data traffic channels TCH/F9.6 and
TCH/F4.8 the
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34594?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I91cfd8f561eb47a5fc48c0682d56331a1d69aded
Gerrit-Change-Number: 34594
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
