Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )

Change subject: pcuif_proto: signal BTS model via PCUIF
......................................................................


Patch Set 1:

(3 comments)

File src/common/pcu_sock.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11632):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/76d0eef8_51be9a97
PS1, Line 363:  switch(bts->variant) {
space required before the open parenthesis '('


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11632):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/7620480e_b65ceca9
PS1, Line 367:         case BTS_OSMO_OC2G:
code indent should use tabs where possible


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11632):
https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/d9b11963_d3bcbc7b
PS1, Line 367:         case BTS_OSMO_OC2G:
please, no spaces at the start of a line



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6
Gerrit-Change-Number: 34648
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 05 Oct 2023 10:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to