Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email )
Change subject: pcu_l1_if: signal BTS model via PCUIF
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
This is something that needs to be done carefully: you're adding a new field,
but the PCUIF version remains unchanged. Old osmo-{bts,bsc} speaking the same
PCUIF version will not include this field, so the INFO.ind message will get
dropped in `pcu_rx()`, see `CHECK_IF_MSG_SIZE`. I know PCUIF sucks when it
comes to adding new fields, I wish at least the INFO.ind would employ TLV
encoding rather than static structure...
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
Gerrit-Change-Number: 34647
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Oct 2023 13:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
