Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Make RLC timing data configurable ...................................................................... Patch Set 2: (4 comments) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/2a852ad1_4b2065fe PS2, Line 50: #define GSM_N3101_STRICT_LOWER_BOUND 8UL > STRICT_LOWER_BOUND means simply "MIN" ? :D Well, no, https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/80fbf532_679c8459 PS2, Line 50: #define GSM_N3101_STRICT_LOWER_BOUND 8UL > STRICT_LOWER_BOUND means simply "MIN" ? :D The spec states that 'N3101 > 8', so it isn't a minimum (it's not an allowed value). I put the strict lower bound and not the minimum as a define, because that's how it's stated in the spec. File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/d1a74a6b_efb0cb0c PS2, Line 51: { .T = 3142, .default_val = 20, > I know tons of parameters are already added here, but we should not continue > adding BTS-specific par […] So, how do I know which timers are BTS-specific or depend on BTS support? I first thought the groupings suggested on https://www.rfwireless-world.com/Terminology/GSM-timers.html (GSM Timers, GSM Timers Network Side(BTS), ...) might make sense, but T3142 isn't listed there as a BTS timer, it's listed as a timer for the mobile side (MSC I guess). I was thinking about adding a group named "bts". Or am I supposed to add several groups for different kinds of BTSs/ File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/623669e9_742473c6 PS2, Line 228: 0x02, 0x00, 0x02, 0xa3, 0x00, 0x09, > why is this changing? are you changing the default values? No default values have been changed. I just added changed the paragraph formatting a bit and added a comment line so that if anyone else reads the code in the future, it's possible to read which octet contains which information without having to go through the entire code. It shouldn't be necessary for anybody to lose time over looking up this information again, at least not for that line. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 Gerrit-Change-Number: 31878 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2023 16:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
