arehbein has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/34671?usp=email )

Change subject: stream (test): Fix Coverity CID 323456
......................................................................

stream (test): Fix Coverity CID 323456

Fix Coverity CID 323456 ("Control flow issues  (NO_EFFECT)") by removing
'greater than 0'-check on unsigned integer-type variable.

Change-Id: I2efb28feae4d4fa7516702f01026af09aa3777ac
---
M tests/stream/stream_test.c
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve




diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c
index e945a1e..960d8fa 100644
--- a/tests/stream/stream_test.c
+++ b/tests/stream/stream_test.c
@@ -678,7 +678,7 @@
        }
        LOGSRV(conn, "Received message from stream (total len including 
stripped headers = %lu)\n",
               osmo_ntohs(h->len) + sizeof(*h));
-       if (ipa_msg_type < 0 || 5 < ipa_msg_type) {
+       if (5 < ipa_msg_type) {
                fprintf(stderr, "Received unexpected IPAC message type 
%"PRIu8"\n", ipa_msg_type);
                return -ENOMSG;
        }

--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34671?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2efb28feae4d4fa7516702f01026af09aa3777ac
Gerrit-Change-Number: 34671
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to