Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/5662/1/src/gprs/gprs_llc.c File src/gprs/gprs_llc.c: Line 375: if (!(msgb_tlli(msg) == mmctx->gb.llme->tlli Global negation is harder to read and I don't think we use this style anywhere. Why not simply .. != .. && .. != ..? -- To view, visit https://gerrit.osmocom.org/5662 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07a40960920dbc594192530c3a145f9a5d2a9c81 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
