Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34649?usp=email )
Change subject: pcuif_proto: signal BTS model via PCUIF ...................................................................... Patch Set 3: (2 comments) File include/osmocom/bsc/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bsc/+/34649/comment/cd042833_73145140 PS2, Line 69: /* BTS model */ > same comments as osmo-pcu patch. Done File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34649/comment/8f6b7098_9bad0abc PS2, Line 310: info_ind->bts_model = PCU_IF_BTS_MODEL_UNSPEC; > Ah, it's osmo-bsc. […] In theory, yes, but in practice no. This would mean that the PCUIF would be connected to osmo-bsc, while the DSP link would be connected to the PCU. BSC, PCU and BTS would run on the same host then. I would exclude this case from here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b58912ad7be3070829614853901aa19108ba2c0 Gerrit-Change-Number: 34649 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 17 Oct 2023 15:13:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment