Attention is currently required from: fixeria, osmith, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email )
Change subject: pcuif_proto: drop support for PCUIF v10 ...................................................................... Patch Set 3: (2 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/d7fef340_d6a631c3 PS1, Line 16: #define PCU_IF_MSG_DATA_CNF 0x01 /* (deprecated) */ > What's the problem in having gaps? Those numbers are not used in the new > version of the protocol, so […] I really se no problem with with having gaps. (I tend to say that we should leave it as it is now) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34706/comment/d94997b0_dfbcf972 PS2, Line 744: if (info_ind->version == 0x0a) { > I think you need to remove this too? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8 Gerrit-Change-Number: 34706 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 09:46:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
