Attention is currently required from: osmith, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email )
Change subject: pcuif_proto: signal BTS model via PCUIF ...................................................................... Patch Set 6: (2 comments) File src/common/pcu_sock.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12005): https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/bd7c27e0_11d17df1 PS6, Line 235: static enum gsm_pcuif_bts_model bts_model_from_variant(enum gsm_bts_type_variant variant) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12005): https://gerrit.osmocom.org/c/osmo-bts/+/34648/comment/e0a784a2_30e4fff6 PS6, Line 247: return PCU_IF_BTS_MODEL_TRX; code indent should use tabs where possible -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34648?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib51238a0e09d4484a539a7f822864189872698b6 Gerrit-Change-Number: 34648 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 10:16:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
